Knob (Typescript): Fix valueTemplate prop type definition #6842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Defect Fixes
Issue #6843
This pull request fixes the TypeScript definition for the
valueTemplate
prop in theKnob
component. The previous type declaration:was incorrect and caused the prop to only accept functions, as
string | undefined
was interpreted as the return type of the function. This made it impossible to directly assign astring
value to thevalueTemplate
prop.The updated type:
correctly allows the prop to accept either:
string | undefined
.string
value.This change ensures the
valueTemplate
prop works as intended with both functions and strings.(and yes, English is not my primary language, so I used ChatGPT to generate this summary)