fix(slider): correct range operation bug #6674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fixes #6649
Resolution
Cause
The slider component didn't handle certain range values correctly when the min and max properties were set, particularly when the range included zero and the model value started at zero.
Example:
In this setup:
Values like [1, 50] and [-1, 50] render correctly within the range. However, when the range starts exactly at 0, the slider incorrectly renders to the left instead of between -1 and 1 as expected.
This issue occurred because the slider's position calculation didn't consider cases where the starting value of the range (0) was at the center of the [min, max] boundary.
Solution
I changed the rangeStartPosition and rangeEndPosition logic a little bit:
Extra
I added a couple of unit tests to validate the behavior of the range property within the slider component.