Fix #6317 InputOtp #6596
Merged
Fix #6317 InputOtp #6596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles iOS/macOS one-time-code autocomplete CustomEvent vs. InputEvent
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the jumbled input when using the autocomplete feature in iOS/macOS to fill a one-time-code field (#6317).
iOS/macOS sends a CustomEvent vs. an InputEvent, and thus has no
inputType. However, it does still need to move to the next input field, otherwise the next character is just appended after the first, resulting in 123456 becoming 165432.I have confirmed that the proof of concept handler used here works: https://stackblitz.com/edit/primevue-4-vite-issue-template-kmmtvs?file=src%2FApp.vue
However, I am unsure of whether there might be other CustomEvents that would fire that would not want to move to the next field. Unfortunately, there were no other identifying characteristics of the event that Apple sends that I could use in order to limit the impact of this change.