Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): resolve $el undefined error #6541

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

KumJungMin
Copy link
Contributor

@KumJungMin KumJungMin commented Oct 8, 2024

Defect Fixes

  • fix Select: throws an error with auto-filter-focus #6539
  • There is an issue where this.$refs.filterInput.$el is not defined when opening the select.
  • Upon investigation, I found that filterInput is only rendered when this.filter is true, so I added the this.filter condition.
this.autoFilterFocus && this.filter && focus(this.$refs.filterInput.$el); // add this.filter 

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 0:25am
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 0:25am

@KumJungMin KumJungMin changed the title fix(Select): allow removal of decimal places fix(Select): resolve $el undefined error Oct 8, 2024
@KumJungMin KumJungMin marked this pull request as ready for review October 8, 2024 12:13
@tugcekucukoglu tugcekucukoglu merged commit a48d2f4 into primefaces:master Nov 12, 2024
7 checks passed
@KumJungMin KumJungMin deleted the fix/issue-6539 branch November 15, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select: throws an error with auto-filter-focus
2 participants