Fix: focus on wrong element when adding "Select" component to footer slot of DatePicker #6480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Please create an issue with a reproducer while sending PR. |
tugcekucukoglu
added
the
Resolution: Needs Revision
|
I created an issue #6482 |
tugcekucukoglu
approved these changes
Sep 26, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix for #6482
I’m working on a customized version of the PrimeVue DatePicker that lets users select hours and minutes using the 'Select' component.
I'm facing an issue where pressing the ArrowDown key focuses on the 'Select' component instead of the calendar dates.
The focus logic is looking for a focusable 'SPAN' element, but instead of stopping at the first one, it continues looping, causing the last element to receive focus.