fix: Typed component props #6477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Eirmas
commented
Sep 25, 2024
Comment on lines
+325
to
+330
| // IftaLabel | ||
| export * from './iftalabel/IftaLabel.vue'; | ||
| export { default as IftaLabel } from './iftalabel/IftaLabel.vue'; | ||
| export * from './iftalabel/style/IftaLabelStyle.js'; | ||
| export { default as IftaLabelStyle } from './iftalabel/style/IftaLabelStyle.js'; | ||
|
|
There was a problem hiding this comment.
This came after running pnpm build
Eirmas
commented
Sep 25, 2024
| @@ -61,4 +61,4 @@ | |||
| "engines": { | |||
| "node": ">=12.11.0" | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Due to pnpm format or pnpm lint:fix
|
I now realize that all type arguments, Props, Slots and Emits are broken. Props are overridden, slots are lost due to an intersection I think the fix from PR #6088 is the best. I would suggest renaming the I'm closing this PR in favor of #6088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #5903
The bug
PrimeVue implements their own
DefineComponentfunction type instead of using the one provided by vue.This is used to simplify the type arguments and allow for only providing the props, slots, emits and sometimes methods.
The issue is that this type function gives empty object to some type arguments related to props, thus overriding the value.
This makes the code intellisense not pick up on the components props correctly.
The fix
This PR replaces the empty objects with the same type functions used by vue. It's more or less a mirror of what they have done.
I also ran build, format and lint:fix before committing my changes, which is why there are changes to other files.
Testing
I tested my changes locally, and I now get the correct props, both the ones from the Vue component, and the public props that Vue normally displays
