Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): emit options of drawer component description error #6465

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Mumujianguang
Copy link
Contributor

###Defect Fixes
#6464

###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 2:29pm
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 2:29pm

@tugcekucukoglu
Copy link
Member

You need to revert the changes that you've added and change this line of the code:

https://github.com/primefaces/primevue/blob/master/packages/primevue/src/drawer/Drawer.d.ts#L257

@tugcekucukoglu tugcekucukoglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Sep 24, 2024
@Mumujianguang
Copy link
Contributor Author

You need to revert the changes that you've added and change this line of the code:

https://github.com/primefaces/primevue/blob/master/packages/primevue/src/drawer/Drawer.d.ts#L257

Can I understand it this way, the /apps/showcase/doc/common/apidoc/index.json generated through packages/primevue? so I just need to change Drawer.d.ts

@tugcekucukoglu tugcekucukoglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Sep 25, 2024
@tugcekucukoglu tugcekucukoglu merged commit 1c288c4 into primefaces:master Sep 25, 2024
3 checks passed
@tugcekucukoglu
Copy link
Member

Correct. Actions generates the json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants