fix DataTable: Allow drop below bottom row #6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes primefaces#6014 by removing the double counting of the page scroll position. The `getOffset()` utility function already includes the window's scroll position (see [here](https://github.com/primefaces/primeuix/blob/20388c576629d62cc9625ba87c1975aba78f85ef/packages/utils/src/dom/methods/getOffset.ts#L6-L7)). Double counting the scroll offset meant that the DataTable `onRowDragOver` event handler always through we were on the top-half of the row, preventing the indicator from being shown at the bottom of the row.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
philipstarkey
changed the title
This was referenced Sep 23, 2024
Closed
tugcekucukoglu
approved these changes
Sep 24, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6014 by removing the double counting of the page scroll position.
The
getOffset()utility function already includes the window's scroll position (see here). Double counting the scroll offset meant that the DataTableonRowDragOverevent handler always thought we were on the top-half of the row, preventing the indicator from being shown at the bottom of the row.