Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6374 Tree: allow filterBy to be a getter #6367

Merged

Conversation

jacobtylerwalls
Copy link
Contributor

@jacobtylerwalls jacobtylerwalls commented Sep 9, 2024

See discussion for the idea.

This 1-line patch allows the filterBy prop of <Tree> to take a getter.

I'm using this successfully in my app, but this patch to primevue would allow me to unwind some workarounds.

Thanks for your consideration, keep up the great work!

Closes #6374

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 8:58pm
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 8:58pm

@tugcekucukoglu tugcekucukoglu added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 10, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.1.0 milestone Sep 10, 2024
@tugcekucukoglu
Copy link
Member

Could you create an issue for this PR?

Thanks for your contribution.

@jacobtylerwalls
Copy link
Contributor Author

No problem! Opened #6374 with a fiddle.

@jacobtylerwalls jacobtylerwalls changed the title Tree: allow filterBy to be a getter #6374 Tree: allow filterBy to be a getter Sep 10, 2024
@tugcekucukoglu tugcekucukoglu removed this from the 4.1.0 milestone Sep 24, 2024
@tugcekucukoglu tugcekucukoglu merged commit 74074bc into primefaces:master Sep 24, 2024
3 of 6 checks passed
@jacobtylerwalls jacobtylerwalls deleted the tree-filter-by-getter branch September 24, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree: Allow filterBy to be a getter
2 participants