Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing of FileUploadState.messages #6322

Merged

Conversation

jacobtylerwalls
Copy link
Contributor

@jacobtylerwalls jacobtylerwalls commented Aug 31, 2024

Fixes #6370

FileUploadState.messages:

  • usually string[]
  • can also be null:

Copy link

vercel bot commented Aug 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2024 9:25pm
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2024 9:25pm

@tugcekucukoglu
Copy link
Member

Could you create an issue while sending PR?

@tugcekucukoglu tugcekucukoglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Sep 10, 2024
@jacobtylerwalls
Copy link
Contributor Author

Sure, I opened #6370 for this.

@tugcekucukoglu tugcekucukoglu merged commit ecd29f7 into primefaces:master Sep 10, 2024
4 of 5 checks passed
@jacobtylerwalls jacobtylerwalls deleted the file-upload-messages-type branch September 10, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileUpload: Fix type of FileUploadState.messages
2 participants