Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Select): avoid IME input issue when typing in filter #6280

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat(Select): avoid IME input issue when typing in filter #6280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/primevue/src/select/Select.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,12 @@ export default {
!this.virtualScrollerDisabled && this.virtualScroller.scrollToIndex(0);
},
onFilterKeyDown(event) {
const isComposing = event.isComposing;

// Avoid IME input issue in Chinese, Japanese and Korean languages
// If they are still typing, do not trigger onFilterKeyDown
if (isComposing) return;

switch (event.code) {
case 'ArrowDown':
this.onArrowDownKey(event);
Expand Down
Loading