Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: global vue type augmentation #6207

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

sceee
Copy link
Contributor

@sceee sceee commented Aug 9, 2024

Defect Fixes

Augment vue types instead of 'vue/types/vue' and '@vue/runtime-core' to fix incompatibility with other libraries caused by the current augmentation behavior

Fixes: #6199

Augment vue types instead of 'vue/types/vue' and '@vue/runtime-core' to fix incompatibility with other libraries caused by the current augmentation behavior

Fixes: primefaces#6199
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 6:58am
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 6:58am

@zyro23
Copy link

zyro23 commented Aug 17, 2024

please backport to v3

@byronogis
Copy link
Contributor

Cool, I've used pnpm patch to verify, this solution is an effective fix. Hope it gets merged soon.

@tugcekucukoglu tugcekucukoglu added the Resolution: Help Wanted Issue or pull request requires extra help and feedback label Aug 21, 2024
@loneil
Copy link
Contributor

loneil commented Aug 23, 2024

+1 to this being important to release for version 3 as well as 4

@frasza
Copy link

frasza commented Aug 25, 2024

🙏

@CMeyer19
Copy link

CMeyer19 commented Sep 3, 2024

Not sure if this change from nuxt needs to be factored into this change: https://nuxt.com/blog/v3-13#vue-typescript-changes.
Will this PR fix the issue ive been getting since upgrading to 3.13, in the plugin.d.ts file of my project the line containing ...node_modules/@primevue/nuxt-module/dist/runtime/plugin.client.mjs").default.. resolves as type of any?

@mertsincan mertsincan merged commit 22cf8be into primefaces:master Sep 4, 2024
4 of 6 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

@fskarmeta
Copy link

fskarmeta commented Nov 12, 2024

hello dear @mertsincan , can we get this update also for version 3 ? this really hinders updating vue and vue-tsc to the latest version for anyone who has not updated to primevue 4 :( thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants