Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel - Empty Slot #5432

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Carousel - Empty Slot #5432

merged 3 commits into from
Apr 2, 2024

Conversation

RodTGG
Copy link
Contributor

@RodTGG RodTGG commented Mar 18, 2024

Small feature request as posted in the following

Discussion: 1455

Added an Empty slot so that the component behaves similar to other data components. e,g, DataView, DataTable

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 10:31am

@tugcekucukoglu
Copy link
Member

Could you create an issue?

@tugcekucukoglu tugcekucukoglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Mar 19, 2024
@RodTGG
Copy link
Contributor Author

RodTGG commented Mar 19, 2024

Could you create an issue?

I cant, i was told to create a discussion first for feature requests.

EDIT: I can only open a bug report which i don't feel this falls under.

removed unused emptyMessage computed
</li>
</ul>
</template>
<div v-else>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wrote in the documentation that an empty slot was added, but you did not make any changes about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, i forgot to sync between work stations and lost the relevant change. Ive replaced the

<div v-else></div>

with an appropriately named slot in the latest commit

<slot name="empty" v-else></slot>

@tugcekucukoglu
Copy link
Member

This PR adds a new feature rather than solving a bug. Enhancement issue report would be more appropriate.

@tugcekucukoglu tugcekucukoglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Apr 2, 2024
@tugcekucukoglu tugcekucukoglu merged commit 038d995 into primefaces:master Apr 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants