-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel - Empty Slot #5432
Carousel - Empty Slot #5432
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Could you create an issue? |
I cant, i was told to create a discussion first for feature requests. EDIT: I can only open a bug report which i don't feel this falls under. |
removed unused emptyMessage computed
components/lib/carousel/Carousel.vue
Outdated
</li> | ||
</ul> | ||
</template> | ||
<div v-else> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You wrote in the documentation that an empty slot was added, but you did not make any changes about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, i forgot to sync between work stations and lost the relevant change. Ive replaced the
<div v-else></div>
with an appropriately named slot in the latest commit
<slot name="empty" v-else></slot>
This PR adds a new feature rather than solving a bug. Enhancement issue report would be more appropriate. |
Small feature request as posted in the following
Discussion: 1455
Added an Empty slot so that the component behaves similar to other data components. e,g, DataView, DataTable