Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4712 Overlaypanel: Overlaypanel closes when any key is pressed #4713

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix #4712 Overlaypanel: Overlaypanel closes when any key is pressed #4713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
851103f
fix: overlaypanel only be closed on escape key pressed
kadirboylu Oct 29, 2023
5e1e7da
fix: add closeOnEscape for onContentKeydown
kadirboylu Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions components/lib/overlaypanel/OverlayPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ export default {
this.unbindOutsideClickListener();
this.unbindScrollListener();
this.unbindResizeListener();
this.unbindDocumentKeyDownListener();
OverlayEventBus.off('overlay-click', this.overlayEventListener);
this.overlayEventListener = null;
this.$emit('hide');
Expand Down Expand Up @@ -167,7 +168,7 @@ export default {
}
},
onContentKeydown(event) {
if (event.code === 'Escape') {
if (event.code === 'Escape' && this.closeOnEscape) {
this.hide();
DomHandler.focus(this.target);
}
Expand All @@ -192,7 +193,7 @@ export default {
}
},
onKeyDown(event) {
if (event.code === 'Escape' || this.closeOnEscape) {
if (event.code === 'Escape' && this.closeOnEscape) {
this.visible = false;
}
},
Expand Down
Loading