Fix #4558 - locale "selectedItemsLabel" is broken on MultiSelect #4588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
I think the linked issue is the same as #3929, so if this lands both can be closed as fixed. |
SoyDiego
approved these changes
Oct 15, 2023
|
Thank you! I appreciate the feedback you've provided, and I find it very valuable. Since .idea is a very simple implementation, we can easily accept it now. Please allow me to ask for separate PRs for different issues or different solutions. |
Not at all. Of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4558 - Prioritize use "selectionMessage" from global config locale else use from props: "selectedItemsLabel"
Also added .idea directory to .gitignore (for Webstorm usage)