Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4567 - DropDown: Labels unassociated from DropDown unless :editable="true" #4572

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

FlipWarthog
Copy link
Contributor

Fix #4567 - DropDown: Labels unassociated from DropDown unless :editable="true"

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2023 11:32pm

@FlipWarthog
Copy link
Contributor Author

@zachlearnscode Works like a charm ;)

@melloware If the ARIA changes are made to PrimeReact and cause the same issue, this can probably be ported at the same time so it keeps working.

@zachlearnscode
Copy link

@FlipWarthog thank you!

@mertsincan mertsincan self-assigned this Oct 10, 2023
@zachlearnscode
Copy link

@FlipWarthog Is there a reason this hasn't been merged to master yet?

@FlipWarthog
Copy link
Contributor Author

@zachlearnscode unfortunately I'm just a contributor. It's up to PrimeTek to merge it.

@zachlearnscode
Copy link

@zachlearnscode unfortunately I'm just a contributor. It's up to PrimeTek to merge it.

Appreciate ya!

@mertsincan mertsincan merged commit d9b5c59 into primefaces:master Dec 22, 2023
2 checks passed
@FlipWarthog FlipWarthog deleted the PV4567 branch December 22, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DropDown: Labels unassociated from DropDown unless :editable="true"
4 participants