Fix #4555 - DataTable: Add nullSortOrder prop #4570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
melloware
approved these changes
Oct 6, 2023
tugcekucukoglu
approved these changes
Oct 10, 2023
MoMack20
reviewed
Oct 17, 2023
|
|
||
| localeComparator() { | ||
| //performance gain using Int.Collator. It is not recommended to use localeCompare against large arrays. | ||
| return new Intl.Collator(undefined, { numeric: true }).compare; |
There was a problem hiding this comment.
The collator only needs to be instantiated once, not once per function call to get the collator.
const localeComparator = new Intl.Collator(undefined, { numeric: true }).compare;
export default {
...
...
localeComparator() {
return localeComparator;
}
}
There was a problem hiding this comment.
There was a problem hiding this comment.
Correct in PrimeReact we only instantiate it once outside of the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4555 - DataTable: Add nullSortOrder prop and better null/undefined handling in component sort functions.