Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Datatable multisortField - Fix undefined values sorting #4556

Closed
wants to merge 1 commit into from

Conversation

MalikBen
Copy link
Contributor

@MalikBen MalikBen commented Oct 5, 2023

Fixes #4555

###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2023 9:27am

@mertsincan
Copy link
Member

Thanks a lot for your contribution! @melloware Have you done any work on this in PrimeReact? If I remember correctly, you added something.

@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 5, 2023
@melloware
Copy link
Member

@mertsincan yes this all works in Primereact and I broke it out into a re-usable static utility in PrimeReact so we can use it every where we sorted and it handles locales and whether you want to sort like Excel with NULLS at top or bottom.

https://github.com/primefaces/primereact/blob/75e535833ab33f971ac66c7712134914415525c5/components/lib/utils/ObjectUtils.js#L377-L401

@melloware
Copy link
Member

@FlipWarthog you know the PrimeVue base a little better than I do but maybe we can port the PrimeReact sorting stuff here to Primevue?

@FlipWarthog
Copy link
Contributor

@melloware Sure, lemme digest what you did on the React side and see how it would fit here

@mertsincan
Copy link
Member

@MalikBen Thanks a lot for your contribution! I think a fix like in PrimeReact might be better. So, closed.

Thanks again,
Best Regards,

@mertsincan mertsincan closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datatable: Sort mode multiple - undefined breaks order
4 participants