Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: autoHide #4126

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Tooltip: autoHide #4126

merged 2 commits into from
Oct 17, 2023

Conversation

MiAnMy
Copy link
Contributor

@MiAnMy MiAnMy commented Jul 11, 2023

#3568

Add autoHide feature, with documentation

@vercel
Copy link

vercel bot commented Jul 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2023 1:17pm

@mertsincan
Copy link
Member

Hi @MiAnMy,

Thanks a lot for your contribution! But, this PR is outdated! Could you please update it? Then, I'll review it asap.

Best Regards,

@mertsincan mertsincan added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Sep 5, 2023
@mertsincan mertsincan added this to the 3.33.1 milestone Sep 5, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.33.1, 3.33.2 Sep 5, 2023
@MiAnMy MiAnMy force-pushed the Tooltip_autohide branch 2 times, most recently from f8bf427 to f9e259e Compare September 5, 2023 13:04
@MiAnMy
Copy link
Contributor Author

MiAnMy commented Sep 5, 2023

Updated

@tugcekucukoglu
Copy link
Member

Thanks for the updates!

I've tried the PR that you have sent. https://stackblitz.com/edit/ywgkvp?file=src%2FApp.vue,src%2Fmain.js%3AL13,src%2FBaseTooltip.js

It seems autoHide demo does not work as expected.

@MiAnMy
Copy link
Contributor Author

MiAnMy commented Sep 5, 2023 •
edited
Loading

@tugcekucukoglu

The given link does not fully contain my changes. If you remove the "pointer-events" attribute in BaseTooltip (.p_tooltip), it should work.

https://stackblitz.com/edit/ywgkvp-5eekri?file=src%2FBaseTooltip.js

@tugcekucukoglu tugcekucukoglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Sep 8, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.34.1, 3.34.2 Sep 8, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.35.0, 3.35.1 Sep 26, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.35.1, 3.35.2 Oct 11, 2023
@tugcekucukoglu tugcekucukoglu merged commit 5b876be into primefaces:master Oct 17, 2023
1 of 2 checks passed
@tugcekucukoglu tugcekucukoglu removed this from the 3.37.0 milestone Oct 17, 2023
@tugcekucukoglu tugcekucukoglu removed their assignment Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiAnMy @mertsincan @tugcekucukoglu