Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: tabindex issue #3984

Closed
wants to merge 6 commits into from
Closed

DataTable: tabindex issue #3984

wants to merge 6 commits into from

Conversation

barthy-koeln
Copy link
Contributor

@barthy-koeln barthy-koeln commented May 24, 2023

Defect Fixes

fixes #3888

Context

I have noticed the bug happening sometimes when navigating away from the DataTable.
I could verify that this solution still sets the tabindex appropriately.

Two steps have been taken to resolve this issue:

  1. Fetch the clicked row at the start of the listener, before any emits might unmount the table.
  2. Still verify if it was found at the end of the listener.

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Jun 10, 2023 5:32pm

@barthy-koeln
Copy link
Contributor Author

After thinking a little, this only fixes the symptom, not the actual problem:

Sometimes the newly clicked element has a totally different index in the DOM that what the event submits.
Will try to debug more.

@barthy-koeln barthy-koeln closed this by deleting the head repository Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTable (Virtual Scroll): Cannot set properties of undefined (setting 'tabIndex')
1 participant