Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualScroller: long waiting time when replacing an array with a smaller size #7208

Closed
MstrVLT opened this issue Feb 6, 2025 · 1 comment
Closed

VirtualScroller: long waiting time when replacing an array with a smaller size #7208

MstrVLT opened this issue Feb 6, 2025 · 1 comment
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.3.0-rc.1

Comments

@MstrVLT
Copy link
Contributor

MstrVLT commented Feb 6, 2025 •
edited
Loading

Describe the bug

VirtualScroller: long wait for applying element changes if scrolling is at the bottom of the list and the size of the list is larger than the applied one.

Pull Request Link

#7207

Other Reason

No response

Reproducer

https://stackblitz.com/edit/rdjblce9-diu8ucun?file=src%2FApp.vue

Environment

Vue version

3.2.45

PrimeVue version

4.2.5

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

If you scroll to the bottom of the page and resize the array elements, the array is applied with delay.

Expected behavior

If you scroll to the bottom of the page and resize the array elements, the array is applied without delay.
@MstrVLT MstrVLT added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 6, 2025
@MstrVLT
Copy link
Contributor Author

MstrVLT commented Feb 6, 2025 •
edited
Loading

Fix #6986
These changes are not enough. if you scroll to the bottom of the list you risk calling onScrollPositionChange many times.
I added an additional check

@MstrVLT MstrVLT changed the title VirtualScroller: long wait, when item is dynamically added VirtualScroller: long wait when replacing a smaller array size Feb 6, 2025
@MstrVLT MstrVLT changed the title VirtualScroller: long wait when replacing a smaller array size VirtualScroller: long waiting time when replacing an array with a smaller size Feb 6, 2025
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 6, 2025
@tugcekucukoglu tugcekucukoglu self-assigned this Feb 6, 2025
@tugcekucukoglu tugcekucukoglu added this to the 4.3.0 milestone Feb 6, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Feb 6, 2025
tugcekucukoglu added a commit that referenced this issue Feb 6, 2025
@tugcekucukoglu
Merge pull request #7207 from MstrVLT/Fix-Issue-#6986
df90418 
fix(VirtualScroller): #7208
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeVue Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeVue
Status: Done
Milestone
4.3.0-rc.1
Development

No branches or pull requests
2 participants
@MstrVLT @tugcekucukoglu