Add generics to type data and newData in DataTableRowEditSaveEvent, DataTableRowEditCancelEvent and DataTableRowEditInitEvent interfaces. DataTable component

[lucasdavidferrero]

The current definition is:

export interface DataTableRowEditSaveEvent {
  originalEvent: Event  
  data: any
  newData: any
  field: string
  index: number
}

An example handling @row-edit-save in DataTable component with current typescript definitions:

async function onRowEditSave (event: DataTableRowEditSaveEvent) {
  let { newData, data, index } = event;
  const newName = newData.fullname // We don't get autocomplete here. It's also unsafe if doing comparations
  const oldName = data.fullname
  if (newName !== oldName) {
    rowData.value[index] = newData  // assigning is unsafe here. rowData entry's type should match newData's type.
  }
}

I think adding a generic for typing data and newData properties will improve DX:

export interface DataTableRowEditSaveEvent<TData> {
  originalEvent: Event  
  data: TData
  newData: TData
  field: string
  index: number
}

This situation of having data and newData happens in other data structures related with the DataTable component such as: DataTableCellEditCompleteEvent, DataTableCellEditCancelEvent, DataTableCellEditInitEvent, DataTableRowCollapseEvent, DataTableRowExpandEvent among others.

Finally but not least, we don't get code suggestion or liting in template when accesing information from a slot prop. Like so:

<Column header="Price" style="min-width: 150px">
  <template #body="{ data }">
      {{ formatPrice(data.price_with_taxes) }}
  </template>
</Column>

We're not getting suggestions when accessing data in template, that increases the change of introduce bugs. It'll really nice that we can also bring a solution to this.

It was discussed here some time ago: Discussion

[github-actions]

Due to PrimeTek's demanding roadmap for PrimeVue and the limited bandwidth of the core team, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨