Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog close button when label is empty #7123

Closed
4 tasks
rgrzesk opened this issue Jan 21, 2025 · 0 comments
Closed
4 tasks

Dialog close button when label is empty #7123

rgrzesk opened this issue Jan 21, 2025 · 0 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.3.0-rc.1

Comments

@rgrzesk
Copy link

rgrzesk commented Jan 21, 2025

Describe the bug

Describe the bug
If you want to create a Dialog with an clos dialog icon and no label, the button will show the literal text " " (without the quotes).
Currently it adds "&nbsp" what breaks the layout:

Image

Similar problem was with ToggleButton: #6809

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-8kuy5ukf?file=src%2FApp.vue

Environment

vue+primevue

Vue version

3.5.13

PrimeVue version

4.2.5

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

create dialog with default sets

Expected behavior

null instead of space
@rgrzesk rgrzesk added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 21, 2025
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 22, 2025
@tugcekucukoglu tugcekucukoglu added this to the 4.3.0 milestone Jan 22, 2025
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 22, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Jan 22, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeVue Jan 22, 2025
@rgrosjean rgrosjean mentioned this issue Feb 25, 2025
Open
4 tasks
rgrosjean added a commit to rgrosjean/primevue that referenced this issue Feb 25, 2025
@rgrosjean
Rollback change from primefaces#7123
7b6be96
@rgrosjean rgrosjean mentioned this issue Feb 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeVue
Status: Done
Milestone
4.3.0-rc.1
Development

No branches or pull requests
2 participants
@rgrzesk @tugcekucukoglu