Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve generated id structure on components/directives #7090

Closed
33 tasks done
mertsincan opened this issue Jan 14, 2025 · 0 comments
Closed
33 tasks done

Improve generated id structure on components/directives #7090

mertsincan opened this issue Jan 14, 2025 · 0 comments
Assignees
@mertsincan
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
4.3.0-rc.1

Comments

@mertsincan
Copy link
Member

mertsincan commented Jan 14, 2025 •
edited
Loading

The BaseComponent and BaseDirective expose two generic variables named $id and $attrSelector. They have the same data for server and client.

Affected Components;

  • Accordion
  • AutoComplete
  • CascadeSelect
  • ContextMenu
  • DataTable
  • DatePicker
  • Dialog
  • Dock
  • DynamicDialog
  • Fieldset
  • Galleria
  • InputChips
  • Listbox
  • MegaMenu
  • Menu
  • Menubar
  • MultiSelect
  • OrderList
  • Panel
  • PanelMenu
  • Password
  • PickList
  • Rating
  • ScrollPanel
  • Select
  • SpeedDial
  • SplitButton
  • Stepper
  • Tabs
  • TabView
  • TieredMenu
  • TreeSelect

Affected Directives;

  • Tooltip
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 14, 2025
@mertsincan mertsincan added this to the 4.3.0 milestone Jan 14, 2025
@mertsincan mertsincan self-assigned this Jan 14, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Jan 14, 2025
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for BaseComponent
2f8e0cc
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Accordion
e8105b8
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for AutoComplete
c7f7480
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for CascadeSelect
e4d4d5c
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for ContextMenu
6148817
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for DataTable
cb346d2
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Dialog
733d2d8
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Fieldset
2b97123
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Galleria
46423fc
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for InputChips
0bfe3ce
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Listbox
b05dac3
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for MegaMenu
cb9867c
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Menu
432e1c7
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Menubar
180fdb8
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for MultiSelect
a980b2e
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for OrderList
0be0511
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for PanelMenu
1095fec
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for PanelMenu
2f27d08
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Password
78e1d46
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for PickList
ba5cad3
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for ScrollPanel
dad72df
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Select
4ba78a8
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for SpeedDial
157883e
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for SplitButton
4a3306b
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Stepper
60c596d
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Tabs
0252af5
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for TabView
6498320
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for TieredMenu
f36d6c0
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for TreeSelect
bb57b0a
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for DataTable
7fb5b39
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for DatePicker
f061fc1
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Dock
08cc312
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for DynamicDialog
b70064c
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Rating
cfdee00
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for DynamicDialog
fc6acef
@mertsincan mertsincan changed the title Improve generated id structure on components Improve generated id structure on components/directives Jan 14, 2025
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for Tooltip
85b7d30
mertsincan added a commit that referenced this issue Jan 14, 2025
@mertsincan
refactor: #7090 for BadgeDirective
ca8d2d9
@mertsincan mertsincan mentioned this issue Jan 14, 2025
Closed
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeVue Jan 14, 2025
tugcekucukoglu added a commit that referenced this issue Feb 10, 2025
@tugcekucukoglu
Refactor #7090 - For Tab
7a3b228
@tugcekucukoglu tugcekucukoglu mentioned this issue Feb 20, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
PrimeVue
Status: Done
Milestone
4.3.0-rc.1
Development

No branches or pull requests
1 participant
@mertsincan