Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual scroller: step prop in delay mode breaks the component #6776

Closed
ndovnar opened this issue Nov 13, 2024 · 0 comments · Fixed by #6862
Closed

Virtual scroller: step prop in delay mode breaks the component #6776

ndovnar opened this issue Nov 13, 2024 · 0 comments · Fixed by #6862
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.2.4

Comments

@ndovnar
Copy link

ndovnar commented Nov 13, 2024 •
edited
Loading

Describe the bug

When the step prop is specified in lazy mode, lazy-load callback isn't called

Reproducer

https://stackblitz.com/edit/tegbzd?file=src%2FApp.vue

PrimeVue version

4.x

Vue version

3.x

Browser(s)

Chrome

Steps to reproduce the behavior

  • setup virtual scroller component
  • make sure add lazy and step are specified
  • scroll
  • verify that lazy-load callback isn't called during the scroll

Expected behavior

lazy-load callback is called while the scrolling
@ndovnar ndovnar added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 13, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 18, 2024
@tugcekucukoglu tugcekucukoglu changed the title Virtual scroller: step prop in lazy mode breaks the component Virtual scroller: step prop in delay mode breaks the component Nov 18, 2024
avramz added a commit to avramz/primevue that referenced this issue Nov 25, 2024
@avramz
primefaces#6776 fix: Virtual scroller: step prop in delay mode breaks…
ea211d6 
… the component

closes primefaces#6776
@avramz avramz mentioned this issue Nov 25, 2024
Merged
@tugcekucukoglu tugcekucukoglu added this to the 4.2.4 milestone Nov 26, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Nov 26, 2024
tugcekucukoglu added a commit that referenced this issue Nov 26, 2024
@tugcekucukoglu
Merge pull request #6862 from avramz/virtual-scroller-lazy
05530cc 
#6776 fix: Virtual scroller: step prop in delay mode breaks the component
@github-project-automation github-project-automation bot moved this to Done in PrimeVue Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeVue
Status: Done
Milestone
4.2.4
Development

Successfully merging a pull request may close this issue.

#6776 fix: Virtual scroller: step prop in delay mode breaks the component avramz/primevue
2 participants
@ndovnar @tugcekucukoglu