Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer: Nested drawer dissmis #6262

Closed
FabienVINCENT opened this issue Aug 20, 2024 · 1 comment
Closed

Drawer: Nested drawer dissmis #6262

FabienVINCENT opened this issue Aug 20, 2024 · 1 comment
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.0.5

Comments

@FabienVINCENT
Copy link
Contributor

Describe the bug

When we have a drawer nested in another and we change the value of "dismissable" the click on the mask of the child closes both

Reproducer

https://stackblitz.com/edit/vitejs-vite-nu6jez?file=src/App.vue

PrimeVue version

4.0.4

Vue version

4.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

No response

Steps to reproduce the behavior

  1. Click to open parent drawer
  2. Inside parent drawer click to open children drawer
  3. Click on the children mask close both

Expected behavior

No response
@FabienVINCENT FabienVINCENT added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 20, 2024
FabienVINCENT added a commit to FabienVINCENT/primevue that referenced this issue Aug 20, 2024
@FabienVINCENT
Fix issue primefaces#6262 - Click outside only when not modal
6866112
@FabienVINCENT FabienVINCENT mentioned this issue Aug 20, 2024
Closed
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 21, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.5 milestone Aug 21, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 21, 2024
@FabienVINCENT
Copy link
Contributor Author

@tugcekucukoglu This is not fixed un 4.0.5 : https://stackblitz.com/edit/vitejs-vite-nu6jez?file=package.json,src/App.vue

FabienVINCENT added a commit to FabienVINCENT/primevue that referenced this issue Aug 23, 2024
@FabienVINCENT
Fix issue primefaces#6262 - Click outside only when not modal for v4.0.5
bb88940
@FabienVINCENT FabienVINCENT mentioned this issue Aug 23, 2024
Merged
LeaderbotX400 pushed a commit to LeaderbotX400/primevue that referenced this issue Aug 29, 2024
@tugcekucukoglu @LeaderbotX400
Fixed primefaces#6262
336c058
tugcekucukoglu added a commit that referenced this issue Sep 11, 2024
@tugcekucukoglu
Merge pull request #6284 from FabienVINCENT/fix-6262-v4.0.5
6ec92cb 
Fix issue #6262 - Click outside only when not modal for v4.0.5
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.0.5
Development

No branches or pull requests
2 participants
@tugcekucukoglu @FabienVINCENT