-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] Popover: Arrow offset uses wrong design token #5755
Labels
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
Milestone
Comments
m-meier
added
the
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
label
May 17, 2024
m-meier
added a commit
to m-meier/primevue
that referenced
this issue
May 17, 2024
mertsincan
pushed a commit
that referenced
this issue
May 17, 2024
mertsincan
added
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
and removed
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
labels
May 17, 2024
Good catch! Thanks a lot for your contribution! |
Yeah, they renamed the design token (e7853c5) but didn't adjust the component, so it uses the wrong name again :-( |
in 4.0.0 it still wrong offset. const mydt = ref({
background: '{amber.500}',
borderRadius: '2rem',
}) <PvPopover ref="op" :dt="mydt">
....
</PvPopover> @ElysaSrc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
Describe the bug
The PopoverStyle.js uses the "popover.arrow.left" design token to position the arrow when the popup reaches the screen border. However the Popover component sets the "overlay.arrow.left" design token in the alignOverlay method.
Therefore the arrow is never repositioned.
Reproducer
https://stackblitz.com/edit/vitejs-vite-rameuq?file=src%2FApp.vue
PrimeVue version
4.0.0-beta.3
Vue version
3.x
Language
TypeScript
Build / Runtime
Vue CLI App
Browser(s)
No response
Steps to reproduce the behavior
Add a button with a popover which is limited by the right side and therefore pushed to the left.
Expected behavior
Arrow should be placed in the correct spot and use the correct design token.
The text was updated successfully, but these errors were encountered: