Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload v4.0.0-beta.3: Subsequent file selections no longer possible in basic mode (regression from v4.0.0-beta.2) #5748

Closed
sceee opened this issue May 15, 2024 · 1 comment
Closed

FileUpload v4.0.0-beta.3: Subsequent file selections no longer possible in basic mode (regression from v4.0.0-beta.2) #5748

sceee opened this issue May 15, 2024 · 1 comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.0.5

Comments

@sceee
Copy link
Contributor

sceee commented May 15, 2024 •
edited
Loading

Describe the bug

After choosing a file in FileUpload basic, you can no longer make a different selection after the first selection was made as the file chooser does no longer open if you click the Choose button after a file was chosen initially.

This is a regression from v4.0.0-beta.2
I think this is the change causing this:
63d04f0#diff-f7197e6585649dd533bfb0f3a1a19e25a1b9bfc436d4b7cb370c221cbb006004R101
If this.hasFiles === true, the input is no longer triggered.

Reproducer

https://stackblitz.com/edit/primevue-create-vue-typescript-issue-template-cepbjp?file=src%2FApp.vue

PrimeVue version

4.0.0-beta.3

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Open the attached stackblitz (or the demo at https://v4.primevue.org/fileupload/#basic )
  2. Click the button to select a file
  3. Choose a file in the file picker
  4. Click the choose button again -> Nothing happens

Expected behavior

When clicking the choose button again after a file was selected, we can make a new file selection that replaces the previous selection.
@sceee sceee added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 15, 2024
@ArchiDevil
Copy link

Same thing. The basic component is useless with custom uploading now.

m-meier pushed a commit to m-meier/primevue that referenced this issue Aug 19, 2024
@kitmeier
fix(FileUpload): fix broken choose button in basic mode, fixes primef…
ff26ce1 
…aces#6257, primefaces#5748

This fix removes the initial code for a transformation to an upload button
since the code is incomplete. It also removes the bug that you cannot
perform additional file selections.
m-meier pushed a commit to m-meier/primevue that referenced this issue Aug 19, 2024
@kitmeier
fix(FileUpload): fix broken choose button in basic mode, fixes primef…
0c5bf84 
…aces#6257, primefaces#5748

This fix removes the initial code for a transformation to an upload button
since the code is incomplete. It also removes the bug that you cannot
perform additional file selections.
@m-meier m-meier mentioned this issue Aug 19, 2024
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 21, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.5 milestone Aug 21, 2024
LeaderbotX400 pushed a commit to LeaderbotX400/primevue that referenced this issue Aug 29, 2024
@kitmeier @LeaderbotX400
fix(FileUpload): fix broken choose button in basic mode, fixes primef…
6e24abd 
…aces#6257, primefaces#5748

This fix removes the initial code for a transformation to an upload button
since the code is incomplete. It also removes the bug that you cannot
perform additional file selections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.0.5
Development

No branches or pull requests
3 participants
@ArchiDevil @sceee @tugcekucukoglu