Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputNumber: Cannot input number 0 in Hungarian(QWERTZ) layout #5577

Closed
csaba215 opened this issue Apr 12, 2024 · 0 comments · Fixed by #5578
Closed

InputNumber: Cannot input number 0 in Hungarian(QWERTZ) layout #5577

csaba215 opened this issue Apr 12, 2024 · 0 comments · Fixed by #5578
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.52.0

Comments

@csaba215
Copy link
Contributor

Describe the bug

Using the hungarian keyboard layou,t the number 0 key is ignored. (Numpad 0 is working)

This bug seems to have been introduced in this commit: ec04c03f82f5b602e072f02d695e0582ec0e39a4

The issue is similar to #5508.

Reproducer

https://primevue.org/inputnumber/

PrimeVue version

3.51.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

1.) Set your keyboard layout to hungarian(QWERTZ)
2.) Go to https://primevue.org/inputnumber/
3.) Using the 0 key under the escape key, try to type in a number 0 or 10.

Expected behavior

The number 0 is inputted.
@csaba215 csaba215 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 12, 2024
csaba215 added a commit to csaba215/primevue that referenced this issue Apr 12, 2024
@csaba215
fix(primefaces#5577): Use event.key instead of event.code for determi…
6819440 
…ning digits
@csaba215 csaba215 mentioned this issue Apr 12, 2024
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 19, 2024
@tugcekucukoglu tugcekucukoglu added this to the 3.52.0 milestone Apr 19, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Apr 19, 2024
tugcekucukoglu added a commit that referenced this issue Apr 19, 2024
@tugcekucukoglu
Merge pull request #5578 from csaba215/fix-5577
8523ff2 
fix(#5577): Use event.key instead of event.code for determining digits
tugcekucukoglu added a commit that referenced this issue Apr 19, 2024
@tugcekucukoglu
Fixed #5577
478885b
@Thiritin Thiritin mentioned this issue May 17, 2024
Closed
tugcekucukoglu added a commit that referenced this issue Jun 10, 2024
@tugcekucukoglu
Refactor #5577
760c98f
@DallinAllred DallinAllred mentioned this issue Jun 22, 2024
Merged
@jennytoc jennytoc mentioned this issue Jun 28, 2024
Open
This was referenced Jul 29, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.52.0
Development

Successfully merging a pull request may close this issue.

fix(#5577): Use event.key instead of event.code for determining digits csaba215/primevue
2 participants
@csaba215 @tugcekucukoglu