Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast: Sticky documentation is misleading #5184

Closed
Tamas-hi opened this issue Jan 31, 2024 · 0 comments · Fixed by #5185
Closed

Toast: Sticky documentation is misleading #5184

Tamas-hi opened this issue Jan 31, 2024 · 0 comments · Fixed by #5185
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
3.48.0

Comments

@Tamas-hi
Copy link
Contributor

Tamas-hi commented Jan 31, 2024 •
edited
Loading

Describe the bug

The current documentation of the sticky behavior of tooltip looks like this:
image

I feel the sentence is gramatically not correct and also misleading (sticky option is set to true by default).
For clarity, I would add the following sentence:

A message disappears after the number of milliseconds defined in the life option. Omit the life option to make the message sticky.

Reproducer

https://stackblitz.com/edit/hysdpx?file=src%2FApp.vue

PrimeVue version

3.47.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Tamas-hi Tamas-hi added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 31, 2024
@Tamas-hi Tamas-hi mentioned this issue Jan 31, 2024
Merged
@tugcekucukoglu tugcekucukoglu added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 1, 2024
@tugcekucukoglu tugcekucukoglu added this to the 3.48.0 milestone Feb 1, 2024
tugcekucukoglu added a commit that referenced this issue Feb 1, 2024
@tugcekucukoglu
Merge pull request #5185 from Tamas-hi/fix-toast-sticky-documentation
736782e 
Fix #5184 - Toast: Sticky option documentation enhancement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
3.48.0
Development

Successfully merging a pull request may close this issue.

Fix #5184 - Toast: Sticky option documentation enhancement Tamas-hi/primevue
2 participants
@tugcekucukoglu @Tamas-hi