Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: esc keypress propagates and triggers close in dialogs #5138

Closed
mfrascati opened this issue Jan 24, 2024 · 5 comments
Closed

Dropdown: esc keypress propagates and triggers close in dialogs #5138

mfrascati opened this issue Jan 24, 2024 · 5 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.49.0

Comments

@mfrascati
Copy link

Describe the bug

I'm using a Dropdown in a DynamicDialog. When ESC is pressed to close the Dropodown options the Dialog component closes as well.
Is it a bug or did I miss how to stop the event propagation?

Reproducer

https://codesandbox.io/p/devbox/sweet-parm-tg9syr

PrimeVue version

3.46

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@mfrascati mfrascati added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 24, 2024
@mertsincan
Copy link
Member

Thanks a lot for your report! I set a milestone for this ticket. We'll check it before the milestone is released.

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 24, 2024
@mertsincan mertsincan modified the milestones: 3.48.0, 3.49.0 Jan 24, 2024
@Daniel-WWU-IT
Copy link

The same happens if a dialog is opened from within another dialog: Pressing ESC closes both dialogs immediately instead of the topmost one.

tugcekucukoglu added a commit that referenced this issue Feb 23, 2024
@tugcekucukoglu
Merge pull request #5269 from primefaces/issue-5138
f230253 
Fixed #5138 - Dropdown: esc keypress propagates and triggers close in…
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Feb 23, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Feb 23, 2024
@veco9
Copy link

veco9 commented Mar 1, 2024

The same happens if a dialog is opened from within another dialog: Pressing ESC closes both dialogs immediately instead of the topmost one.

This is still an issue.

@manjindersinghsarkaria
Copy link

Having same issue with Calendar inside the OverlayPanel.

@1Map
Copy link
Contributor

1Map commented Jul 15, 2024

Also having the same issue with multiple modal Dialogs. Pressing Esc on current dialog closes dialog as well as all other modal dialogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.49.0
Development

No branches or pull requests
7 participants
@1Map @mfrascati @mertsincan @tugcekucukoglu @veco9 @Daniel-WWU-IT @manjindersinghsarkaria