Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests in the master branch are failing #5095

Closed
haoqunjiang opened this issue Jan 17, 2024 · 1 comment
Closed

Unit tests in the master branch are failing #5095

haoqunjiang opened this issue Jan 17, 2024 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@haoqunjiang
Copy link
Contributor

Describe the bug

Hi, I'm working on https://github.com/vuejs/ecosystem-ci
Considering PrimeVue is such a popular library, I plan to integrate this project into the ecosystem-ci to make sure any new Vue bug fixes or features would not break PrimeVue.

However, I noticed that a few unit tests started failing since v3.45.0.
I would like to help resolve these issues so that we can run PrimeVue's tests in the ecosystem-ci.

But I'm not sure if it's the tests that are outdated or if these failures are real regressions.

Reproducer

https://github.com/primefaces/primevue.git

PrimeVue version

3.47.0

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

git clone https://github.com/primefaces/primevue.git
cd primevue
npm ci
npm run test:unit

Expected behavior

In 3.44:

 Test Files  82 passed (82)
      Tests  583 passed (583)

In the current master branch:

 Test Files  7 failed | 75 passed (82)
      Tests  17 failed | 566 passed (583)
@haoqunjiang haoqunjiang added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 17, 2024
@mertsincan
Copy link
Member

Hi @sodatea,

Thanks a lot for your interest! We would be pleased if you support us with PR on this issue. We are currently making improvements regarding accessibility, new features and modern styling. That's why we haven't had time to adapt the tests to them yet. We will try to fix existing tests in the core before the next version is released. Of course, you can contribute to this with PR. I want you to know that we will focus more on tests in 2024. We are trying to complete all our shortcomings step by step.

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 17, 2024
@mertsincan mertsincan added this to the 3.47.0 milestone Jan 17, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 18, 2024
@avramz avramz mentioned this issue Aug 1, 2024
9 tasks
tugcekucukoglu added a commit that referenced this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants