-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown: After selecting an option, clearing the value using close icon should clear the filter input #5060
Comments
…he value using close icon should clear the filter input
This is an issue that I recently fixed in Primeng. Link for reference - Primeng PR link for reference - primefaces/primeng#14511. Also fixed the same in PrimeReact - primefaces/primereact#5736 |
Hi, Thanks a lot for your PR and enhancement! But, this is not the right behaviour. They are independent of each other. It is normal for the filter to remain when you clear the value. For example, when you try an editable Dropdown in the same case and delete the selected text without using clearIcon, the filter will still remain. Please try with clearIcon and without clearIcon. Best Regards, |
Also, this type of enhancement can be supported with a prop and the filter can be cleared only when pressing clearIcon.
|
I hope you are working on it. Let me know if you need my help in anything. Thanks, |
Honestly, a PR would be nice :) |
Sure @mertsincan, will update the PR within next 12 hours |
…he value using close icon should clear the filter input
@mertsincan Updated the PR with the changes you requested. |
…sing close icon should clear the filter input (#5061) * fix: #5060, Dropdown: After selecting an option, clearing the value using close icon should clear the filter input * fix: #5060, Dropdown: After selecting an option, clearing the value using close icon should clear the filter input --------- Co-authored-by: Akshay Antony <[email protected]>
Describe the bug
Dropdown: After selecting an option, clearing the value using close icon should clear the filter input.
Reproducer
https://stackblitz.com/edit/mfbhvb?file=src%2FApp.vue
PrimeVue version
3.46
Vue version
3.x
Language
TypeScript
Build / Runtime
Vue CLI App
Browser(s)
No response
Steps to reproduce the behavior
Expected behavior
On clicking the clear icon, the previously typed value in the filter should clear.
The text was updated successfully, but these errors were encountered: