Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Error BaseStyle__default.default is undefined #4648

Closed
chu121su12 opened this issue Oct 19, 2023 · 0 comments · Fixed by #4649
Closed

core: Error BaseStyle__default.default is undefined #4648

chu121su12 opened this issue Oct 19, 2023 · 0 comments · Fixed by #4649
Assignees
@mertsincan @tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.40.0

Comments

@chu121su12
Copy link
Contributor

chu121su12 commented Oct 19, 2023 •
edited
Loading

Describe the bug

When using core.js, there is TypeError:

image

I think it is caused by this import sequence:

primevue/rollup.config.js

Lines 172 to 175 in bcb7814

'primevue/config': 'primevue.config',
...CORE_STYLE_DEPENDENCIES,
'primevue/usestyle': 'primevue.usestyle',
'primevue/base': 'primevue.base',

That's causing this.primevue.base get overriden later:

image

PrimeVue version

3.37.0

Vue version

3.x

Browser(s)

all

Steps to reproduce the behavior

Use the cdn script directly in browser:

<script src="https://cdnjs.cloudflare.com/ajax/libs/vue/3.3.4/vue.global.prod.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/primevue/3.37.0/core/core.min.js"></script>

Expected behavior

No error generated
@chu121su12 chu121su12 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 19, 2023
@chu121su12 chu121su12 mentioned this issue Oct 19, 2023
Merged
@mertsincan mertsincan added this to the 3.38.0 milestone Oct 23, 2023
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 23, 2023
@mertsincan mertsincan modified the milestones: 3.38.0, 3.38.2 Oct 26, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.39.0, 3.x, 4.x, 3.40.0 Nov 1, 2023
tugcekucukoglu added a commit that referenced this issue Nov 6, 2023
@tugcekucukoglu
Merge pull request #4649 from chu121su12/patch-1
66806e9 
Fix #4648 - Reorder core import
tugcekucukoglu added a commit that referenced this issue Nov 6, 2023
@tugcekucukoglu
Refactor #4648
3164234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.40.0
Development

Successfully merging a pull request may close this issue.

Fix #4648 - Reorder core import chu121su12/primevue
3 participants
@chu121su12 @mertsincan @tugcekucukoglu