Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderList: Missing moveUpButtonProps #4581

Closed
rory-instil opened this issue Oct 10, 2023 · 2 comments
Closed

OrderList: Missing moveUpButtonProps #4581

rory-instil opened this issue Oct 10, 2023 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@rory-instil
Copy link
Contributor

Describe the bug

According to the documentation there is a a moveTopButtonProps on the OrderList component: https://primevue.org/orderlist/#api.orderlist.props.moveTopButtonProps
On attempting to use this component however it does not work.

On looking at the source it appears that this was present before but was refactored out accidentally afterwards (with the other three buttons moveUpButtonProps, moveDownButtonProps, and moveBottomButtonProps remaining as expected): https://github.com/primefaces/primevue/blob/master/components/lib/orderlist/OrderList.vue#L5-L32

In the reproduction you can see how 3 out of the 4 buttons are disabled with the props unable to be applied to the Move Top button

Reproducer

https://codesandbox.io/s/nifty-forest-nyxwyw

PrimeVue version

3.32.1

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

Try to use :move-top-button-props="{ disabled: false }" and see that button is still disabled / property is not available

Expected behavior

  • Apply :move-top-button-props="{ disabled: false }" to OrderList
  • Move top button is enabled by default
@rory-instil rory-instil added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 10, 2023
@FlipWarthog
Copy link
Contributor

@rory-instil This issue still has the default name. Should be renamed something like "OrderList: Missing moveUpButtonProps"

@rory-instil rory-instil changed the title Component Name: Issue Title Cannot assign properties to Move Top button in OrderList Oct 10, 2023
@rory-instil rory-instil changed the title Cannot assign properties to Move Top button in OrderList OrderList: Missing moveUpButtonProps Oct 10, 2023
@rory-instil
Copy link
Contributor Author

@rory-instil This issue still has the default name. Should be renamed something like "OrderList: Missing moveUpButtonProps"

Yup! Sorry about that.

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 10, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.35.1 milestone Oct 10, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Oct 10, 2023
@tugcekucukoglu tugcekucukoglu changed the title OrderList: Missing moveUpButtonProps OrderList: Missing button props Oct 10, 2023
tugcekucukoglu added a commit that referenced this issue Oct 10, 2023
tugcekucukoglu added a commit that referenced this issue Oct 10, 2023
@tugcekucukoglu tugcekucukoglu changed the title OrderList: Missing button props OrderList: Missing moveUpButtonProps Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants