Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeTable: Missing dataKey property #4273

Closed
Hulkmaster opened this issue Aug 15, 2023 · 1 comment · Fixed by #4936
Closed

TreeTable: Missing dataKey property #4273

Hulkmaster opened this issue Aug 15, 2023 · 1 comment · Fixed by #4936
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.45.0

Comments

@Hulkmaster
Copy link

Describe the bug

current treeTable is hardcoded to use key property from dataset, which breaks usage of api endpoints, which uses key property for different purpose

dataTable allows custom "key" property to be used

https://primevue.org/datatable/#api.datatable.props.dataKey
image

whereas treeTable doesn't, which requires to enrich api data with custom property just for specific component
it will also be incompatible with any api response, which uses "key" for another purpose

Reproducer

https://primevue.org/treetable/

PrimeVue version

3.32.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Hulkmaster Hulkmaster added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 15, 2023
tengju added a commit to tengju/primevue that referenced this issue Dec 6, 2023
@tengju
primefaces#4273 Add support for dataKey on TreeTable
d813685
@tengju tengju mentioned this issue Dec 6, 2023
Merged
@tengju
Copy link
Contributor

tengju commented Dec 7, 2023

I have made a PR which should add the support for the dataKey, awaiting for an approval now

mertsincan pushed a commit that referenced this issue Dec 19, 2023
@tengju
#4273 Add support for dataKey on TreeTable (#4936)
435de17
@mertsincan mertsincan added this to the 3.45.0 milestone Dec 19, 2023
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.45.0
Development

Successfully merging a pull request may close this issue.

#4273 Add support for dataKey on TreeTable tengju/primevue
3 participants
@Hulkmaster @mertsincan @tengju