Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitButton: Not rendering icon slot without icon property #4200

Closed
ig-onoffice-de opened this issue Jul 24, 2023 · 0 comments · Fixed by #4339
Closed

SplitButton: Not rendering icon slot without icon property #4200

ig-onoffice-de opened this issue Jul 24, 2023 · 0 comments · Fixed by #4339
Assignees
@bahadirsofuoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.33.0

Comments

@ig-onoffice-de
Copy link
Contributor

Describe the bug

I use the SplitButton and want to render an icon on the default button. To do so, I want to use the icon slot not the property.
So I add the slot, but the slot is only shown if there is also any icon property present.
Shouldn't they be independent of each other?

Reproducer

https://codesandbox.io/p/sandbox/youthful-rgb-hpscmd?welcome=true

PrimeVue version

3.30.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. See the first SplitButton in Reproduction Link showing the icon slot
  2. See the second (does not have the icon prop set) not showing the icon slot

Expected behavior

icon slot should be shown if passed not depending on the icon prop
@ig-onoffice-de ig-onoffice-de added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 24, 2023
@bahadirsofuoglu bahadirsofuoglu self-assigned this Aug 28, 2023
@bahadirsofuoglu bahadirsofuoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 28, 2023
@bahadirsofuoglu bahadirsofuoglu added this to the 3.32.3 milestone Aug 28, 2023
@bahadirsofuoglu bahadirsofuoglu mentioned this issue Aug 28, 2023
Merged
tugcekucukoglu added a commit that referenced this issue Sep 1, 2023
@tugcekucukoglu
Refactor #4200
83f0a8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahadirsofuoglu bahadirsofuoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.33.0
Development

Successfully merging a pull request may close this issue.

SplitButton: Slot icon updates primefaces/primevue
2 participants
@bahadirsofuoglu @ig-onoffice-de