-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataGrid: Invalid typing of slot props #3395
Labels
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
Milestone
Comments
Magiczne
added
the
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
label
Dec 13, 2022
tugcekucukoglu
added
Resolution: Cannot Replicate
Issue could not be replicated by Core Team
and removed
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
labels
Dec 14, 2022
We're unable to replicate your issue, if you are able to create a reproducer or add details please edit this issue. This issue will be closed if no activities in 20 days. |
Will prepare reproduction today/tommorrow |
@tugcekucukoglu - I've added reproduction codesandbox. |
volvachev
added a commit
to volvachev/primevue
that referenced
this issue
Dec 18, 2022
volvachev
added a commit
to volvachev/primevue
that referenced
this issue
Dec 19, 2022
tugcekucukoglu
added
Status: Pending Review
Issue or pull request is being reviewed by Core Team
and removed
Resolution: Cannot Replicate
Issue could not be replicated by Core Team
labels
Jan 9, 2023
How can we replicate the problem? The link is broken. |
tugcekucukoglu
added
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
and removed
Status: Pending Review
Issue or pull request is being reviewed by Core Team
labels
Apr 5, 2023
volvachev
added a commit
to volvachev/primevue
that referenced
this issue
Apr 11, 2023
mertsincan
pushed a commit
that referenced
this issue
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
Describe the bug
When using scoped slots for column header/footer in data grid, typescript will complain for typings of the slot props.
For example
TS Will complain:
error TS2551: Property 'props' does not exist on type 'Column'. Did you mean '$props'?
In the templates the
$
is removed, so the typings should be updatedReproducer
https://codesandbox.io/s/vite-primevue-forked-7rl78b?file=/src/App.vue
Happen when using vite + vite-tsc
Would probably appear in the VS Code using Volar extension
PrimeVue version
3.20
Vue version
3.x
Language
TypeScript
Build / Runtime
Vite
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
No response
The text was updated successfully, but these errors were encountered: