Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog block UI removes page scroll #145

Closed
fairking opened this issue Jan 16, 2020 · 1 comment
Closed

Dialog block UI removes page scroll #145

fairking opened this issue Jan 16, 2020 · 1 comment
Assignees
@mertsincan
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
1.0.1

Comments

@fairking
Copy link

fairking commented Jan 16, 2020 •
edited
Loading

Dialog block UI removes page scroll and does not restore it back when the dialog is closed. So you cannot scroll page, even when go to different page.
@yigitfindikli yigitfindikli self-assigned this Jan 17, 2020
@yigitfindikli yigitfindikli added this to the 1.0.1 milestone Jan 17, 2020
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 17, 2020
@Merve7 Merve7 self-assigned this Jan 17, 2020
@Merve7 Merve7 closed this as completed in 1c7b1aa Jan 17, 2020
Merve7 added a commit that referenced this issue Jan 17, 2020
@Merve7
Revert "Fixed #145"
d944b45 
This reverts commit 1c7b1aa.
@Merve7 Merve7 reopened this Jan 17, 2020
@Merve7 Merve7 closed this as completed in fb253ef Jan 17, 2020
@cagataycivici cagataycivici self-assigned this Jan 20, 2020
@cagataycivici
Copy link
Member

Reopen for review

@cagataycivici cagataycivici reopened this Jan 20, 2020
@fairking fairking mentioned this issue Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
5 participants
@cagataycivici @Merve7 @mertsincan @fairking @yigitfindikli