Skip to content

Commit

Permalink
Merge pull request #6142 from clemvnt/fix/dialog-focus
Browse files Browse the repository at this point in the history
Dialog: Cherry pick 're-focus original element on close' fix to v4
  • Loading branch information
tugcekucukoglu authored Aug 1, 2024
2 parents 655798b + e3a52f6 commit e70a844
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
8 changes: 7 additions & 1 deletion packages/primevue/src/confirmpopup/ConfirmPopup.vue
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ export default {
visible: false,
confirmation: null,
autoFocusAccept: null,
autoFocusReject: null
autoFocusReject: null,
target: null
};
},
target: null,
Expand Down Expand Up @@ -175,6 +176,8 @@ export default {
this.autoFocusAccept = this.confirmation.defaultFocus === undefined || this.confirmation.defaultFocus === 'accept' ? true : false;
this.autoFocusReject = this.confirmation.defaultFocus === 'reject' ? true : false;
this.target = document.activeElement;
this.bindOutsideClickListener();
this.bindScrollListener();
this.bindResizeListener();
Expand All @@ -188,6 +191,9 @@ export default {
this.autoFocusAccept = null;
this.autoFocusReject = null;
DomHandler.focus(this.target);
this.target = null;
this.unbindOutsideClickListener();
this.unbindScrollListener();
this.unbindResizeListener();
Expand Down
6 changes: 5 additions & 1 deletion packages/primevue/src/dialog/Dialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ export default {
containerVisible: this.visible,
maximized: false,
focusableMax: null,
focusableClose: null
focusableClose: null,
target: null,
};
},
watch: {
Expand Down Expand Up @@ -147,6 +148,7 @@ export default {
},
onEnter() {
this.$emit('show');
this.target = document.activeElement;
this.focus();
this.enableDocumentSettings();
this.bindGlobalListeners();
Expand All @@ -162,6 +164,8 @@ export default {
},
onLeave() {
this.$emit('hide');
DomHandler.focus(this.target);
this.target = null;
this.focusableClose = null;
this.focusableMax = null;
},
Expand Down

0 comments on commit e70a844

Please sign in to comment.