Refactor #3965 - Refactor on Dialog

primefaces · Jul 5, 2023 · e65a1ee · e65a1ee
1 parent 3014b22
commit e65a1ee
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/components/lib/dialog/BaseDialog.vue b/components/lib/dialog/BaseDialog.vue
@@ -160,13 +160,18 @@ const inlineStyles = {
 };
 
 const classes = {
-    mask: ({ props, instance }) => [
-        'p-dialog-mask',
-        {
-            'p-component-overlay p-component-overlay-enter': props.modal
-        },
-        instance.getPositionClass()
-    ],
+    mask: ({ props }) => {
+        const positions = ['left', 'right', 'top', 'topleft', 'topright', 'bottom', 'bottomleft', 'bottomright'];
+        const pos = positions.find((item) => item === props.position);
+
+        return [
+            'p-dialog-mask',
+            {
+                'p-component-overlay p-component-overlay-enter': props.modal
+            },
+            pos ? `p-dialog-${pos}` : ''
+        ];
+    },
     root: ({ props, instance }) => [
         'p-dialog p-component',
         {

diff --git a/components/lib/dialog/Dialog.vue b/components/lib/dialog/Dialog.vue
@@ -222,12 +222,6 @@ export default {
                 this.documentKeydownListener = null;
             }
         },
-        getPositionClass() {
-            const positions = ['left', 'right', 'top', 'topleft', 'topright', 'bottom', 'bottomleft', 'bottomright'];
-            const pos = positions.find((item) => item === this.position);
-
-            return pos ? `p-dialog-${pos}` : '';
-        },
         containerRef(el) {
             this.container = el;
         },