Merge pull request #4713 from kadirboylu/master

Fix #4712 Overlaypanel: Overlaypanel closes when any key is pressed
primefaces · Oct 31, 2023 · 6f342ad · 6f342ad
2 parents 06bb56c + 5e1e7da
commit 6f342ad
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/components/lib/overlaypanel/OverlayPanel.vue b/components/lib/overlaypanel/OverlayPanel.vue
@@ -139,6 +139,7 @@ export default {
             this.unbindOutsideClickListener();
             this.unbindScrollListener();
             this.unbindResizeListener();
+            this.unbindDocumentKeyDownListener();
             OverlayEventBus.off('overlay-click', this.overlayEventListener);
             this.overlayEventListener = null;
             this.$emit('hide');
@@ -167,7 +168,7 @@ export default {
             }
         },
         onContentKeydown(event) {
-            if (event.code === 'Escape') {
+            if (event.code === 'Escape' && this.closeOnEscape) {
                 this.hide();
                 DomHandler.focus(this.target);
             }
@@ -192,7 +193,7 @@ export default {
             }
         },
         onKeyDown(event) {
-            if (event.code === 'Escape' || this.closeOnEscape) {
+            if (event.code === 'Escape' && this.closeOnEscape) {
                 this.visible = false;
             }
         },