Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2878: Tooltip global respect data-pr-position #2884

Closed
wants to merge 3 commits into from

Conversation

melloware
Copy link
Member

###Defect Fixes
Fix #2878: Tooltip global respect data-pr-position

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 12, 2022
@mertsincan
Copy link
Member

Hi @melloware,

Thanks a lot for this PR! I've seen some bugs in Tooltip related to this issue. Generally, we use methods to change the state, but try to use the new state before the component is updated. The problem seems to come from them. Fixed now. 3125839

@mertsincan mertsincan closed this May 30, 2022
@melloware melloware deleted the PR2878 branch May 30, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip: data-pr-position doesn't change where the tooltip goes
2 participants