Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aria-label and aria-labelledby attributes on all input components. #839

Closed
efc opened this issue Apr 7, 2019 · 5 comments · Fixed by #3323, #3349 or #3350
Closed

Allow aria-label and aria-labelledby attributes on all input components. #839

efc opened this issue Apr 7, 2019 · 5 comments · Fixed by #3323, #3349 or #3350
Assignees
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@efc
Copy link

efc commented Apr 7, 2019

[ ] bug report
[X] feature request
[ ] support request

Current behavior

I cannot associate aria-label or aria-labelledby attributes with Dropdown or other PrimeReact input components. (This was noted in issue #729, but that issue was closed without addressing this request.)

Expected behavior

I would expect that I could define a Dropdown and any other PrimeReact input components like this:

<Dropdown value='test' editable={true} options={[]} ariaLabel='Test' />

or

<Dropdown value='test' editable={true} options={[]} ariaLabelledby='testid' />
  • React version:
    16.8.6

  • PrimeReact version:
    3.1.2

  • Browser:
    all

  • Language:
    all

@mertsincan
Copy link
Member

mertsincan commented Apr 22, 2019

Components;

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label May 30, 2019
@arnauddem
Copy link
Contributor

arnauddem commented Jun 21, 2019

  • InputSwitch should also allow aria attributes (not handled in primereact 3.1.2)
  • Checkbox should also allow aria attributes (already have inputId to set <label htmlFor="id"/> but sometimes need to have aria-label different than <label>.

@mertsincan mertsincan added this to the 6.1.0 milestone Feb 9, 2021
@mertsincan mertsincan modified the milestones: 6.1.0, 7.0.0 Mar 9, 2021
@ankitprahladsoni
Copy link

Will you add this support for InputNumber as well? Right now it only has aria-labelledby attribute.

@jeffgaynorspok
Copy link

aria-* for accessibility and data-* for testing should be passed through on the root of all components.

@melloware
Copy link
Member

@jeffgaynorspok this feature was added in this ticket: #2620

@melloware melloware added the Component: Accessibility Issue or pull request is related to WCAG or ARIA label Apr 9, 2022
@mertsincan mertsincan modified the milestones: 8.2.0, 9.0.0 Jul 6, 2022
@melloware melloware self-assigned this Sep 14, 2022
@melloware melloware modified the milestones: 9.0.0, 8.6.0 Sep 14, 2022
melloware added a commit to melloware/primereact that referenced this issue Sep 14, 2022
melloware added a commit to melloware/primereact that referenced this issue Sep 21, 2022
melloware added a commit to melloware/primereact that referenced this issue Sep 21, 2022
melloware added a commit that referenced this issue Sep 21, 2022
melloware added a commit to melloware/primereact that referenced this issue Sep 21, 2022
melloware added a commit that referenced this issue Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
7 participants