Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this.props.onSelectionChange is not a function in DataTable #641

Closed
sisisin opened this issue Nov 14, 2018 · 0 comments
Closed

this.props.onSelectionChange is not a function in DataTable #641

sisisin opened this issue Nov 14, 2018 · 0 comments
Assignees
@Merve7
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
2.0.0

Comments

@sisisin
Copy link

sisisin commented Nov 14, 2018 •
edited
Loading 

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Plunkr case

https://plnkr.co/edit/yIzG6zkR63M5j7lwxroO?p=preview

Current behavior

When click table row, It occurred this.props.onSelectionChange is not a function error.

Expected behavior

Has no error.

Please tell us about your environment:

  • React version:
  • PrimeReact version:
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]

see plunkr
sisisin added a commit to sisisin/primereact that referenced this issue Nov 14, 2018
@sisisin
Fixed primefaces#641 need to check nullable props
eddc61b
@sisisin sisisin mentioned this issue Nov 14, 2018
Closed
@Merve7 Merve7 added this to the 2.0.0-rc.1 milestone Nov 26, 2018
@Merve7 Merve7 self-assigned this Nov 26, 2018
@Merve7 Merve7 closed this as completed in 835f40b Nov 27, 2018
@Merve7 Merve7 added the Type: Bug Issue contains a defect related to a specific component. label Nov 27, 2018
@Merve7 Merve7 modified the milestones: 2.0.0-rc.1, 2.0.0 Nov 28, 2018
@cagataycivici cagataycivici changed the title this.props.onSelectionChange is not a function this.props.onSelectionChange is not a function in DataTable Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merve7 Merve7

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@sisisin @Merve7