Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: After selecting an option, clearing the value using close icon should clear the filter input #5735

Closed
akshayaqburst opened this issue Jan 11, 2024 · 2 comments · Fixed by #5736
Closed

Dropdown: After selecting an option, clearing the value using close icon should clear the filter input #5735

akshayaqburst opened this issue Jan 11, 2024 · 2 comments · Fixed by #5736
Assignees
@akshayaqburst
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.3.2

Comments

@akshayaqburst
Copy link
Contributor

Describe the bug

Dropdown: After selecting an option, clearing the value using close icon should clear the filter input.

Reproducer

No response

PrimeReact version

10.3.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primereact.org/dropdown/#filter
  2. Pass showClear prop to clear the selected option using close icon.
  3. Type desired value in the dropdown's filter field.
  4. Select an option based on the ones provided post-filtering.
  5. Unwrap dropdown.
  6. Observe that the previously typed value in the filter field has not been cleared.
  7. Clear the dropdown value by clicking on the clear icon.
  8. Observe that the previously typed value in the filter field has not been cleared.

Expected behavior

On clicking the clear icon, the previously typed value in the filter should clear.
@akshayaqburst akshayaqburst added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 11, 2024
akshayaqburst pushed a commit to qburst/primereact_qb_22 that referenced this issue Jan 11, 2024
@akshayantony55
fix: primefaces#5735, Dropdown: After selecting an option, clearing t…
86774c5 
…he value using close icon should clear the filter input
@akshayaqburst akshayaqburst mentioned this issue Jan 11, 2024
Merged
@akshayaqburst
Copy link
Contributor Author

@melloware This is an issue that I recently fixed in Primeng. Link for reference - Primeng PR link for reference - primefaces/primeng#14511

akshayaqburst pushed a commit to qburst/primereact_qb_22 that referenced this issue Jan 11, 2024
@akshayantony55
fix: primefaces#5735, Dropdown: After selecting an option, clearing t…
693cca6 
…he value using close icon should clear the filter input
@melloware melloware added this to the 10.4.0 milestone Jan 11, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 11, 2024
melloware pushed a commit that referenced this issue Jan 11, 2024
@akshayaqburst
fix: #5735, Dropdown: After selecting an option, clearing the value u…
058de22 
…sing close icon should clear the filter input (#5736)
@melloware
Copy link
Member

Excellent thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshayaqburst akshayaqburst

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.3.2
2 participants
@melloware @akshayaqburst