Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm Dialog: Demo opening dialog 3 times #5697

Closed
melloware opened this issue Jan 5, 2024 · 1 comment · Fixed by #5698
Closed

Confirm Dialog: Demo opening dialog 3 times #5697

melloware opened this issue Jan 5, 2024 · 1 comment · Fixed by #5698
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.3.1

Comments

@melloware
Copy link
Member

Describe the bug

Running npm run dev against 10.3.1 is showing the Confirm Dialog 3 times

Reproducer

No response

PrimeReact version

10.3.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@melloware melloware added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a defect related to a specific component. labels Jan 5, 2024
@melloware
Copy link
Member Author

melloware commented Jan 5, 2024 •
edited
Loading

@kl-nevermore i have to revert your change.

If you run npm run dev and go to the Confirm Dialog you will see it goes haywire and opens 3 dialogs.

    const getCurrentProps = () => Object.assign(props, confirmProps.current);
    const getPropValue = (key) => Object.assign(props, confirmProps.current)[key];

image

@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 5, 2024
@melloware melloware self-assigned this Jan 5, 2024
@melloware melloware added this to the 10.3.1 milestone Jan 5, 2024
melloware added a commit to melloware/primereact that referenced this issue Jan 5, 2024
@melloware
Fix primefaces#5697: Revert ConfirmDialog fix
061704b
@melloware melloware mentioned this issue Jan 5, 2024
Merged
melloware added a commit that referenced this issue Jan 5, 2024
@melloware
Fix #5697: Revert ConfirmDialog fix (#5698)
2874e8a
@melloware melloware modified the milestones: 10.3.1, 10.4.0 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.3.1
Development

Successfully merging a pull request may close this issue.

Fix #5697: Revert ConfirmDialog fix melloware/primereact
1 participant
@melloware