Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabView: Closes all tabs on click #5369

Closed
waqarmalyk opened this issue Nov 22, 2023 · 1 comment · Fixed by #5371
Closed

TabView: Closes all tabs on click #5369

waqarmalyk opened this issue Nov 22, 2023 · 1 comment · Fixed by #5371
Assignees
@melloware
Labels
Component: Documentation Issue or pull request is related to Documentation Resolution: Workaround Issue or pull request contains a workaround. It needs to be reviewed further by Core Team
Milestone
10.2.0

Comments

@waqarmalyk
Copy link

Describe the bug

This is provided example from Primereact Tabs

Before

After click on one tab closes all tabs

Tabs gone

Reproducer

https://stackblitz.com/edit/react-6mzgc4-rthpe1?file=src%2FApp.js

PrimeReact version

latest

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

No response
@waqarmalyk waqarmalyk added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 22, 2023
@melloware
Copy link
Member

@waqarmalyk workaround is it works if you give each tab a unique key so it can be identified properly: https://stackblitz.com/edit/react-6mzgc4-v6xplm?file=src%2FApp.js

@melloware melloware self-assigned this Nov 22, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. Resolution: Workaround Issue or pull request contains a workaround. It needs to be reviewed further by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 22, 2023
@melloware melloware added this to the 10.2.0 milestone Nov 22, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 22, 2023
@melloware
Fix primefaces#5369: TabView showcase for closeable
47e83ab
@melloware melloware mentioned this issue Nov 22, 2023
Merged
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Type: Bug Issue contains a defect related to a specific component. labels Nov 22, 2023
melloware added a commit that referenced this issue Nov 22, 2023
@melloware
Fix #5369: TabView showcase for closeable (#5371)
a2fc4b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Documentation Issue or pull request is related to Documentation Resolution: Workaround Issue or pull request contains a workaround. It needs to be reviewed further by Core Team
Projects
None yet
Milestone
10.2.0
Development

Successfully merging a pull request may close this issue.

Fix #5369: TabView showcase for closeable melloware/primereact
2 participants
@melloware @waqarmalyk