Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: Footer Option #4200

Closed
onursenture opened this issue Mar 29, 2023 · 5 comments · Fixed by #4296
Closed

Panel: Footer Option #4200

onursenture opened this issue Mar 29, 2023 · 5 comments · Fixed by #4296
Assignees
@habubey
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
9.4.0

Comments

@onursenture
Copy link
Member

Describe the feature you would like to see added

Footer is needed for Panel component. Check PrimeNG (https://primeng.org/panel):

image

Is your feature request related to a problem?

No response

Describe the solution you'd like

No response

Describe alternatives you have considered

No response

Additional context

No response
@onursenture onursenture added Type: New Feature Issue contains a new feature or new component request Status: Discussion Issue or pull request needs to be discussed by Core Team labels Mar 29, 2023
@habubey habubey self-assigned this Mar 29, 2023
habubey added a commit that referenced this issue Apr 27, 2023
@habubey
Fix #4200: Panel Footer Option
26714b3
@habubey habubey linked a pull request Apr 27, 2023 that will close this issue
Fix #4200: Panel Footer Option #4296
Merged
habubey added a commit that referenced this issue Apr 27, 2023
@habubey
Merge pull request #4296 from primefaces/issue-4200
d960d2c 
Fix #4200: Panel Footer Option
@melloware melloware removed the Status: Discussion Issue or pull request needs to be discussed by Core Team label Apr 27, 2023
@melloware melloware added this to the 9.4.0 milestone Apr 27, 2023
@Aperrix
Copy link

Aperrix commented Oct 3, 2023 •
edited
Loading

Hi everyone !

As i can see, the footer option is not yet available for the panel component in v10, is it normal ?

@melloware
Copy link
Member

@Aperrix I see the property right here: https://primereact.org/panel/#api.Panel.props.footer

Are you saying its not working?

@melloware
Copy link
Member

Seems like its working fine: https://stackblitz.com/edit/react-6nqxwp

@Aperrix
Copy link

Aperrix commented Oct 3, 2023 •
edited
Loading

@Aperrix I see the property right here: https://primereact.org/panel/#api.Panel.props.footer

Are you saying its not working?

It's not documented in the "Features" and "Theming" tab of the panel component page.

And the border-radius is not correct
image

@melloware
Copy link
Member

I would open a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@habubey habubey

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
9.4.0
Development

Successfully merging a pull request may close this issue.

Fix #4200: Panel Footer Option primefaces/primereact
4 participants
@onursenture @melloware @Aperrix @habubey