Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onColReorder return columns: undefined #389

Closed
Rarity opened this issue Apr 23, 2018 · 1 comment · Fixed by #390
Closed

onColReorder return columns: undefined #389

Rarity opened this issue Apr 23, 2018 · 1 comment · Fixed by #390
Assignees
@mertsincan
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
1.5.2

Comments

@Rarity
Copy link
Contributor

Rarity commented Apr 23, 2018 •
edited
Loading 

[x] bug report

Plunkr Case (Bug Reports)
Please fork the plunkr below and create a case demonstrating your bug report. Issues without a plunkr have much less possibility to be reviewed.

Current behavior
event in onColReorder method return columns: undefined

Expected behavior
event in onColReorder method should return column list

Minimal reproduction of the problem with instructions
Look console after reorder column
https://plnkr.co/edit/hTW5tm8brpHb9EpzchRh?p=preview

  • React version:
    16.3.1

  • PrimeReact version:
    1.5.1

  • Browser: All

  • Language: All
@Rarity Rarity mentioned this issue Apr 23, 2018
Merged
mertsincan added a commit that referenced this issue Apr 25, 2018
@mertsincan
Merge pull request #390 from Rarity/master
cc5d77b 
fixed #389
@mertsincan
Copy link
Member

Thanks a lot for the PR!

@mertsincan mertsincan self-assigned this Apr 25, 2018
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Apr 25, 2018
@mertsincan mertsincan added this to the 1.6.0 milestone Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
1.5.2
Development

Successfully merging a pull request may close this issue.

fix onColumnDrop method Rarity/primereact
2 participants
@Rarity @mertsincan